[FFmpeg-devel] [PATCH v2] checkasm: vvc: Use checkasm_check for printing failing output

[Ronald S. Bultje]

Hi,

On Mon, Dec 9, 2024 at 5:02 PM Martin Storsjö <martin at martin.st> wrote:

> Share the checkasm_check_pixel macro from hevc_pel in checkasm.h,
> to allow other tests to use the same. (To use it in other tests,
> those tests need to have a similar setup for high bitdepth pixels,
> with a local variable named "bit_depth".)
>
> This simplifies the code for checking the output, and can print
> the failing output (including a map of matching/mismatching
> elements) if checkasm is run with the -v/--verbose option.
> ---
> v2: Moved the macro to checkasm.h and added a comment about where
> it works and what it assumes. I checked that other checkasm tests
> like vp9dsp also have a similarly matching bit_depth parameter,
> so it might work quite well there too.
> ---
>  tests/checkasm/checkasm.h | 12 ++++++++++++
>  tests/checkasm/hevc_pel.c |  9 ---------
>  tests/checkasm/vvc_alf.c  | 10 ++--------
>  3 files changed, 14 insertions(+), 17 deletions(-)
>

No further comments from me - LGTM.

Ronald