[FFmpeg-devel] [FFmpeg-cvslog] avutil/csp: add av_csp_trc_inv_from_id()

[Michael Niedermayer]

Hi

On Thu, Dec 05, 2024 at 11:28:54AM +0000, Niklas Haas wrote:
> ffmpeg | branch: master | Niklas Haas <git at haasn.dev> | Mon Nov 25 13:35:34 2024 +0100| [bf0a6c4111184ffab9f157db7ee7c8a0f59df077] | committer: Niklas Haas
> 
> avutil/csp: add av_csp_trc_inv_from_id()
> 
> Mathematical inverse of av_csp_trc_from_id(), plus testing to make sure it
> roundtrips correctly with the corresponding TRC.
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=bf0a6c4111184ffab9f157db7ee7c8a0f59df077
> ---
> 
>  doc/APIchanges                |   3 +
>  libavutil/csp.c               | 155 ++++++++++-
>  libavutil/csp.h               |   5 +
>  libavutil/tests/color_utils.c |  13 +-
>  libavutil/version.h           |   4 +-
>  tests/ref/fate/color_utils    | 608 +++++++++++++++++++++---------------------
>  6 files changed, 470 insertions(+), 318 deletions(-)

Breaks x86-32

TEST    color_utils
--- src/tests/ref/fate/color_utils	2024-12-06 21:02:29.850814721 +0100
+++ tests/data/fate/color_utils	2024-12-06 21:02:42.958917771 +0100
@@ -263,42 +263,4 @@
 trc=smpte2084 calling func(15123.456700) expected=1.042921 roundtrip=15123.456700
 trc=smpte2084 calling func(19845.889230) expected=1.070677 roundtrip=19845.889230
 trc=smpte2084 calling func(98678.423100) expected=1.225908 roundtrip=98678.423100
-trc=smpte2084 calling func(99999.899998) expected=1.227127 roundtrip=99999.899998
-trc=smpte428 calling func(-0.100000) expected=0.000000 roundtrip=0.000000
-trc=smpte428 calling func(-0.018054) expected=0.000000 roundtrip=0.000000
-trc=smpte428 calling func(-0.010000) expected=0.000000 roundtrip=0.000000
-trc=smpte428 calling func(-0.004490) expected=0.000000 roundtrip=0.000000
-trc=smpte428 calling func(0.000000) expected=0.000000 roundtrip=0.000000
-trc=smpte428 calling func(0.003162) expected=0.105659 roundtrip=0.003162
-trc=smpte428 calling func(0.005000) expected=0.126018 roundtrip=0.005000
-trc=smpte428 calling func(0.009000) expected=0.157985 roundtrip=0.009000
-trc=smpte428 calling func(0.015000) expected=0.192284 roundtrip=0.015000
-trc=smpte428 calling func(0.100000) expected=0.398869 roundtrip=0.100000
-trc=smpte428 calling func(1.000000) expected=0.967043 roundtrip=1.000000
-trc=smpte428 calling func(52.370000) expected=4.432321 roundtrip=52.370000
-trc=smpte428 calling func(125.098765) expected=6.195572 roundtrip=125.098765
-trc=smpte428 calling func(1999.111230) expected=17.988639 roundtrip=1999.111230
-trc=smpte428 calling func(6945.443000) expected=29.041734 roundtrip=6945.443000
-trc=smpte428 calling func(15123.456700) expected=39.174525 roundtrip=15123.456700
-trc=smpte428 calling func(19845.889230) expected=43.490646 roundtrip=19845.889230
-trc=smpte428 calling func(98678.423100) expected=80.593559 roundtrip=98678.423100
-trc=smpte428 calling func(99999.899998) expected=81.006971 roundtrip=99999.899998
-trc=arib-std-b67 calling func(-0.100000) expected=0.000000 roundtrip=0.000000
-trc=arib-std-b67 calling func(-0.018054) expected=0.000000 roundtrip=0.000000
-trc=arib-std-b67 calling func(-0.010000) expected=0.000000 roundtrip=0.000000
-trc=arib-std-b67 calling func(-0.004490) expected=0.000000 roundtrip=0.000000
-trc=arib-std-b67 calling func(0.000000) expected=0.000000 roundtrip=0.000000
-trc=arib-std-b67 calling func(0.003162) expected=0.097400 roundtrip=0.003162
-trc=arib-std-b67 calling func(0.005000) expected=0.122474 roundtrip=0.005000
-trc=arib-std-b67 calling func(0.009000) expected=0.164317 roundtrip=0.009000
-trc=arib-std-b67 calling func(0.015000) expected=0.212132 roundtrip=0.015000
-trc=arib-std-b67 calling func(0.100000) expected=0.544089 roundtrip=0.100000
-trc=arib-std-b67 calling func(1.000000) expected=1.000000 roundtrip=1.000000
-trc=arib-std-b67 calling func(52.370000) expected=1.712092 roundtrip=52.370000
-trc=arib-std-b67 calling func(125.098765) expected=1.867862 roundtrip=125.098765
-trc=arib-std-b67 calling func(1999.111230) expected=2.363502 roundtrip=1999.111230
-trc=arib-std-b67 calling func(6945.443000) expected=2.586219 roundtrip=6945.443000
-trc=arib-std-b67 calling func(15123.456700) expected=2.725380 roundtrip=15123.456700
-trc=arib-std-b67 calling func(19845.889230) expected=2.773978 roundtrip=19845.889230
-trc=arib-std-b67 calling func(98678.423100) expected=3.060803 roundtrip=98678.423100
-trc=arib-std-b67 calling func(99999.899998) expected=3.063182 roundtrip=99999.899998
+  FAIL
Test color_utils failed. Look at tests/data/fate/color_utils.err for details.
make: *** [src/tests/Makefile:311: fate-color_utils] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241206/845c7ea6/attachment.sig>