[FFmpeg-devel] [PATCH v2] avcodec: add Mediacodec audio decoders support

[Matthieu Bouron]

On Mon, Aug 26, 2024 at 01:59:32PM +0200, Anton Khirnov wrote:
> Quoting Zhao Zhili (2024-08-26 13:52:41)
> > 
> > 
> > > On Aug 24, 2024, at 22:40, Matthieu Bouron <matthieu.bouron at gmail.com> wrote:
> > > 
> > > ---
> > > 
> > > Diff with the v1:
> > > - dropped support of ENCODING_PCM_24BIT_PACKED as it uses 3 consecutive bytes
> > >  for one sample and there is no direct AVSampleFormat equivalent (that would
> > >  require a dedicated copy routine to copy the 3 bytes into the 4 bytes
> > >  provided by AV_SAMPLE_FMT_S32). I believe this is something that can be added
> > >  later on.
> > > - Addressed all comments except the one about the assert failure using
> > >  `/ffmpeg_g -c:a opus_mediacodec -i /sdcard/opus.mp4 -f null -`. Maybe it is
> > >  fixed by your recent patch related to the draining state of the decoder ?
> > 
> > I still get the same assert failure with and only with opus
> 
> Why should it support opus again? Or flac or any other
> patent-unecumbered codec?

My mistake. I forgot to drop their support (which is done in the v3
patch).

-- 
Matthieu B.