[FFmpeg-devel] [PATCH 4/4] swscale/aarch64: add nv24/nv42 to yuv420p unscaled converter

[Martin Storsjö]

On Thu, 15 Aug 2024, Ramiro Polla wrote:

> Thank you for the review. New patch attached.

Thanks - this looks very straightforward and nice now! Just one minor nit 
below:

> +        add             x4, x4, x5, sxtw            // src1 += srcPadding
> +        add             x9, x9, x5, sxtw            // src2 += srcPadding
> +        add             x0, x0, x1, sxtw            // dst1 += dstPadding1
> +        add             x2, x2, x3, sxtw            // dst2 += dstPadding2

Since you're doing sxtw, I would have expected to have the last register 
referenced as wN, not xN. I'd guess that some picky versions of assemblers 
could error out due to this, so it could be good to change that just to be 
safe.

Other than that, this looks extremely straightforward and nice.

// Martin