[FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

[Dale Curtis]

Thanks, disable-h274-film-grain and applying it to hevc too sgtm. I'll wait
to see what Niklas says before updating though.

- dale

On Tue, Aug 13, 2024 at 12:47 PM James Almer <jamrial at gmail.com> wrote:

> On 8/13/2024 4:31 PM, Dale Curtis wrote:
> > Film grain support adds a huge amount of overhead to the H264Context
> > structure for a feature that is rarely used. On low end devices or
> > pages that have lots of media this bloats memory usage rapidly.
> >
> > This introduces a --disable-h264-film-grain option which makes
> > these fields optional and reduces the H264Context size from
> > 851808 bytes to 53444 bytes.
> >
> > Bug: https://crbug.com/359358875
> > Signed-off-by: Dale Curtis <dalecurtis at chromium.org>
> >
> > Note: I'm not sure this is the right way to go about making this
> optional,
> > please
> > let me know if there's a better way.
> >
> > - dale
>
> The proper name for the option and define should be H274, or simply
> film_grain if you're also including AV1FG in it.
> I'm not against a change like this, but it needs to be thorough like we
> did with iamfenc and iamfdec, and there's more code handling film grain
> in other modules.
>
> Not sure what Niklas thinks.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>