[FFmpeg-devel] [PATCH] avcodec/vvcdec: move vvcdec.{c, h} to the top directory

James Almer jamrial at gmail.com
Wed Apr 3 17:46:14 EEST 2024


On 4/3/2024 5:35 AM, Anton Khirnov wrote:
> Quoting James Almer (2024-04-02 21:28:28)
>> On 4/2/2024 4:25 PM, Andreas Rheinhardt wrote:
>>> James Almer:
>>>> As it's the main file declaring the AVCodec.
>>>
>>> And why is that supposed to be an advantage?
>>
>> It's not, it's a cosmetic change. Makes it easier to find at least one
>> file containing the core code in the base directory.
>> And I'd like to do the same for other big modules with 3+ source files.
>> hevc, h264, vp9, etc.
> 
> I dislike this.

Any particular reason why? I'd really like to get some consistency in 
the lavc folder. bsfs are currently all in their own folder, but 
decoders, encoders and hwaccels are in the top directory alongside all 
the generic code, save for vvc and a h26x shared folder. And then 
there's the arch folders.

My idea was something like

libavcodec/foodec.{c,h}
libavcodec/fooenc.{c,h}
libavcodec/foo/foo_$bar.{c,h}
libavcodec/foo/$arch/foo*.{asm,c,h}

> 
> Though I would be in favor of removing the vvc prefix from the file
> names, as it's redundant with dirname.

I wouldn't oppose.


More information about the ffmpeg-devel mailing list