[FFmpeg-devel] [PATCH] Extract av_hls_codec_attr

[Michael Niedermayer]

On Sun, Oct 29, 2023 at 08:05:50PM -0500, Romain Beauxis wrote:
> The logic for extracting HLS codec attribute strings is very useful and
> can be re-used in many different situations when working with HLS
> streams using libavcodec/libavformat.
> 
> This patch extracts the function's code and places it into a publicly
> available function.
> 
> ---
>  libavcodec/Makefile  |   2 +
>  libavcodec/hls.c     | 105 +++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/hls.h     |  42 +++++++++++++++++
>  libavformat/hlsenc.c |  83 +++-------------------------------

you cannot call ff_* functions across libs

they need to start with av* / avpriv*


[...]
> +              rbsp_buf = ff_nal_unit_extract_rbsp(data, remain_size, &rbsp_size, 0);

libavcodec/libavcodec.so: undefined reference to `ff_nal_unit_extract_rbsp'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:133: recipe for target 'ffmpeg_g' failed
make: *** [ffmpeg_g] Error 1
make: *** Waiting for unfinished jobs....
libavcodec/libavcodec.so: undefined reference to `ff_nal_unit_extract_rbsp'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:133: recipe for target 'ffplay_g' failed
make: *** [ffplay_g] Error 1

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20231031/75fd4d6c/attachment.sig>