[FFmpeg-devel] [PATCH v1] avcodec/vp9_superframe_split_bsf: Fix for possible null pointer dereference

[Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics]

Pointer  ctx->priv_data->buffer_pkt->data, that can have only NULL value (checked at vp9_superframe_split_bsf.c:48), is dereferenced at vp9_superframe_split_bsf.c:57.


> -----Original Message-----
> From: Dawid Kozinski <d.kozinski at samsung.com>
> Sent: piątek, 6 października 2023 13:02
> To: d.frankiewic at samsung.com; ffmpeg-devel at ffmpeg.org
> Cc: Dawid Kozinski <d.kozinski at samsung.com>
> Subject: [PATCH v1] avcodec/vp9_superframe_split_bsf: Fix for possible null
> pointer dereference
> 
> Signed-off-by: Dawid Kozinski <d.kozinski at samsung.com>
> ---
>  libavcodec/vp9_superframe_split_bsf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/vp9_superframe_split_bsf.c
> b/libavcodec/vp9_superframe_split_bsf.c
> index cddd48119c..4f94afc6d9 100644
> --- a/libavcodec/vp9_superframe_split_bsf.c
> +++ b/libavcodec/vp9_superframe_split_bsf.c
> @@ -45,7 +45,7 @@ static int vp9_superframe_split_filter(AVBSFContext *ctx,
> AVPacket *out)
>      int i, j, ret, marker;
>      int is_superframe = !!s->buffer_pkt->data;
> 
> -    if (!s->buffer_pkt->data) {
> +    if (s->buffer_pkt->data) {
>          ret = ff_bsf_get_packet_ref(ctx, s->buffer_pkt);
>          if (ret < 0)
>              return ret;
> --
> 2.25.1