[FFmpeg-devel] [PATCH 1/3] avfilter/vf_ssim360: Use correct type in sizeof

Anton Khirnov anton at khirnov.net
Tue Mar 14 07:43:23 EET 2023


Quoting Andreas Rheinhardt (2023-03-12 22:52:49)
> SSIM360Context.ssim360_hist is an array of four pointers to double;
> so sizeof(*ssim360_hist[0]) (=sizeof(double)) is the correct size
> to use to calculate the amount of memory to allocate, not
> sizeof(*ssim360_hist) (which is sizeof(double*)).
> 
> Use FF_ALLOCZ_TYPED_ARRAY to avoid this issue altogether.
> 
> Fixes Coverity issue #1520671.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  libavfilter/vf_ssim360.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks ok.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list