[FFmpeg-devel] [PATCH v2 4/4] decklink_enc: add support for SMPTE 2038 VANC packet output

[Marton Balint]

On Thu, 22 Jun 2023, Devin Heitmueller wrote:

> On Tue, Jun 6, 2023 at 2:56 PM Devin Heitmueller
> <devin.heitmueller at ltnglobal.com> wrote:
>> You indicated in patch 0/4 that you had some additional
>> feedback/comments on this patch series.  Could you please provide
>> them?  I've got other data formats I'm working on support for (i.e.
>> SCTE-104) which depend on the common changes in this patch.
>
> <ping>

Sorry for the delay. Could you please rebase the patch on current master? 
Also two comments:

- I don't think you need av_packet_clone() before putting the packet into 
the queue. Yes, audio and video use it, but only because only a single 
pointer can be stored in the decklink frame. But the avpacket queue you 
are using stores whole packet structs, and the muxer is 
allowed to unref the packet it gets in write_packet() as far as I 
know.

- Could you use a more specific name for the queue size? Like 
"vanc_queue_size", not to be confused with audio/video. And please add 
documentation for it in docs/outdev.texi.

Thanks,
Marton