[FFmpeg-devel] [PATCH] avcodec/j2kenc: use uint64_t type for the lambda value

[Michael Niedermayer]

On Sat, Jun 24, 2023 at 02:12:45PM -0300, James Almer wrote:
> Should fix integer overflows, and improve encoding results.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavcodec/j2kenc.c                              | 4 ++--
>  tests/ref/vsynth/vsynth1-jpeg2000-yuva444p16     | 8 ++++----
>  tests/ref/vsynth/vsynth2-jpeg2000-yuva444p16     | 8 ++++----
>  tests/ref/vsynth/vsynth3-jpeg2000-yuva444p16     | 8 ++++----
>  tests/ref/vsynth/vsynth_lena-jpeg2000-yuva444p16 | 8 ++++----
>  5 files changed, 18 insertions(+), 18 deletions(-)

LGTM
have you checked that unsigned 64bit will not overflow too ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230624/f5bd6be9/attachment.sig>