[FFmpeg-devel] [RFC] SDR

[James Almer]

On 6/22/2023 1:09 PM, Anton Khirnov wrote:
> Hi,
> I'm sorry to say, the patch at its current state is quite far from
> something I'd consider acceptable for git master.
> 
> 1) Given that there are sdr and sdrfile demuxers, it seems to me that
> the transport layer should be split into a protocol rather than be
> inside the demuxer

I disagree. It's not a protocol. I can't get a Matroska bitstream out of 
this like i could from an actual protocol like http, smb, etc. This is a 
capture device.

> 2) Threading inside the demuxer, with pthread calls randomly sprinkled
> throughout is particularly ugly and dangerous. Demuxers should not do
> their own threading.
> 3) sdr_read_header() and sdr_read_packet() are giant, hideous, and
> unreadable.
> 4) Why does there seem to be drawing code in a demuxer?