[FFmpeg-devel] [PATCH] fftools/ffmpeg_enc: Prevent duplicate A53 Closed Captions at frame rate up-conversion

Devin Heitmueller devin.heitmueller at ltnglobal.com
Tue Jun 13 17:16:27 EEST 2023


On Sat, Jun 10, 2023 at 11:55 PM Anton Khirnov <anton at khirnov.net> wrote:
> I don't think there's a fundamental reason -r handling could not be
> moved to lavfi, but it's a nontrivial task. E.g. the dup/drop counts are
> integrated with the CLI and would have to be exported from lavfi somehow
> if you wanted to keep that functionality.

I think the big question here in my mind is:  does anyone actually
care about the dup/drop counts?  I recognize it's a change in behavior
for the application to not show that in the status, but how useful is
it really to know that the app duplicated 50% of your frames because
you put "-r 60000/1001" on the command line?

I could go further in suggesting it's actually misleading, as people
might very well think there is a problem that resulted in frames being
dropped or duplicated, when in fact it's expected behavior if you
specify "-r" on the command-line.  Adding to the confusion is the fact
that "-r" and "-vf fps" behave differently in terms of how the status
is shown to the user (even though from a user's standpoint they are
doing the same thing).

Devin

-- 
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com  e: devin.heitmueller at ltnglobal.com


More information about the ffmpeg-devel mailing list