[FFmpeg-devel] [PATCH 4/5] avformat/jpegxl_probe: inline various ret < 0 checks

James Almer jamrial at gmail.com
Fri Jun 9 05:44:38 EEST 2023


On 6/8/2023 11:32 PM, Anton Khirnov wrote:
> Quoting Leo Izen (2023-06-08 16:26:36)
>> Inlines some ret < 0 checks to look like:
>>      if ((ret = func()) < 0)
>>          return ret;
>>
>> which clarifies code slightly.
> 
> FWIW I find this variant less readable.
> But it's your code, so up to you.

Agree. It's both less readable and more prone to mistakes.


More information about the ffmpeg-devel mailing list