[FFmpeg-devel] [PATCH 3/3] avcodec/decode: fill missing frame fields for all decoders

Anton Khirnov anton at khirnov.net
Sun Jul 9 15:58:58 EEST 2023


Quoting James Almer (2023-07-09 14:05:45)
> On 7/9/2023 6:49 AM, Anton Khirnov wrote:
> > Quoting James Almer (2023-07-08 21:00:38)
> >> And not just those with the old decode() API.
> >>
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> >> ---
> >>   libavcodec/decode.c | 52 +++++++++++++++++++++++----------------------
> >>   1 file changed, 27 insertions(+), 25 deletions(-)
> > 
> > Is there a functional reason for this patch?
> > 
> > I've been wondering recently about dropping this code entirely, because
> > get_buffer() should always fill those fields.
> 
> Decoders that don't use get_buffer at all exist. If they don't fill all 
> frame fields, this would.

Ah well, there's more of those than I thought.
No objections then.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list