[FFmpeg-devel] [PATCH] lavfi: get rid of FF_INTERNAL_FIELDS

[Paul B Mahol]

On 1/31/23, Nicolas George <george at nsup.org> wrote:
> Anton Khirnov (12023-01-31):
>> I find this a significant improvement in code quality, making it easier
>> to maintain.
>
> You can say that, you do not maintain it.
>
>> Making it obvious which field is private and which is public is a
>> feature, not a bug.
>
> Then I do not want this feature. Making people expend effort for no
> reason at all.
>
>> I'll also note that
>> - we've been switching to this precise pattern everywhere else in the
>>   project
>
> Well, too bad.
>
>> - the most prolific lavfi contributor recently (Paul) has no objections
>>   to this patch
>> - the second most prolific lavfi contributor recently (Andreas) told me
>>   on IRC he planned to write this same patch himself
>
> It is not a matter of volume, it is a matter of complexity. Since
> Stefano is no longer involved in the coding, I am the only one who knows
> how the tricky bits of libavfilter work.

No, you do not. Calling your libavfilter framework code "complex" is disgrace
to really complex code in non-framework part of libavfilter or else in
FFmpeg libraries.

libavfilter framework needs serious overhaul.
It have numerous limitations and other stuff too much exposed to user,
that really should
not be.

You do not maintain code at all, you just block patches and never
contribute anymore anything useful besides blocking patches.

>
>> So if you insist on objecting to this patch, it seems to me that a vote
>> would be in order.
>
> Well, go ahead, but please be aware that a vote cannot force me to
> maintain that code.
>
> If this project goes over my objections “that patch makes my maintenance
> work harder”, then be very careful to involve in your plans “find
> somebody else willing to debug the code of libavfilter”. Good luck.
>
> In fact, I think I will take it very easy with maintenance duty until
> further notice. I am really fed up with the direction this project is
> taking. Authoritarianism, that was the other side of the fork, and we
> all know what happened there. And who is to blame.
>
> --
>   Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>