[FFmpeg-devel] [PATCH] avformat: deprecate AVFormatContext io_close callback

[Anton Khirnov]

Quoting Marton Balint (2023-02-14 21:30:09)
> 
> 
> On Tue, 14 Feb 2023, Anton Khirnov wrote:
> 
> > Quoting Marton Balint (2023-02-13 22:37:54)
> >> diff --git a/libavformat/version.h b/libavformat/version.h
> >> index 904e7f06aa..7ff1483912 100644
> >> --- a/libavformat/version.h
> >> +++ b/libavformat/version.h
> >> @@ -31,7 +31,7 @@
> >>
> >>  #include "version_major.h"
> >>
> >> -#define LIBAVFORMAT_VERSION_MINOR   2
> >> +#define LIBAVFORMAT_VERSION_MINOR   3
> >
> > I don't think this needs a version bump, because nothing about the API
> > or ABI changes with this commit, it's just an expression of intent to
> > change it in the future.
> 
> My concern with not increasing the version number is that the entry in 
> doc/APIChanges will not point to the version where the change happened...

I don't see that as a problem, because the relevant question from the
user perspective is "in what version was the replacement for <x> added"
rather than "in what version was <x> deprecated", since one should
always use the newer API when it is present.

-- 
Anton Khirnov