[FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files.

[Nicolas George]

Hi.

Matt Oliver (12023-01-15):
>  vf_nlmeans and vf_atadenoisedont contain any code on 32bit x86 so dont
> build them.

Hi

This sentence seems to be missing a few words.


> 
> ---
>  libavfilter/x86/Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/libavfilter/x86/Makefile b/libavfilter/x86/Makefile
> index e87481bd7a..9a68b9204b 100644
> --- a/libavfilter/x86/Makefile
> +++ b/libavfilter/x86/Makefile
> @@ -44,7 +44,9 @@ X86ASM-OBJS-$(CONFIG_SCENE_SAD)              +=
> x86/scene_sad.o
> 
>  X86ASM-OBJS-$(CONFIG_AFIR_FILTER)            += x86/af_afir.o
>  X86ASM-OBJS-$(CONFIG_ANLMDN_FILTER)          += x86/af_anlmdn.o

> +ifdef ARCH_X86_64
>  X86ASM-OBJS-$(CONFIG_ATADENOISE_FILTER)      += x86/vf_atadenoise.o
> +endif

Do you mean the file is useless yet configure set
CONFIG_ATADENOISE_FILTER? That looks suspicious.

The same goes for the other place and the other patch.

>  X86ASM-OBJS-$(CONFIG_BLEND_FILTER)           += x86/vf_blend.o
>  X86ASM-OBJS-$(CONFIG_BWDIF_FILTER)           += x86/vf_bwdif.o
>  X86ASM-OBJS-$(CONFIG_COLORSPACE_FILTER)      += x86/colorspacedsp.o
> @@ -62,7 +64,9 @@ X86ASM-OBJS-$(CONFIG_LIMITER_FILTER)         +=
> x86/vf_limiter.o
>  X86ASM-OBJS-$(CONFIG_LUT3D_FILTER)           += x86/vf_lut3d.o
>  X86ASM-OBJS-$(CONFIG_MASKEDCLAMP_FILTER)     += x86/vf_maskedclamp.o
>  X86ASM-OBJS-$(CONFIG_MASKEDMERGE_FILTER)     += x86/vf_maskedmerge.o
> +ifdef ARCH_X86_64
>  X86ASM-OBJS-$(CONFIG_NLMEANS_FILTER)         += x86/vf_nlmeans.o
> +endif
>  X86ASM-OBJS-$(CONFIG_OVERLAY_FILTER)         += x86/vf_overlay.o
>  X86ASM-OBJS-$(CONFIG_PP7_FILTER)             += x86/vf_pp7.o
>  X86ASM-OBJS-$(CONFIG_PSNR_FILTER)            += x86/vf_psnr.o

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230211/ffbd3a5f/attachment.sig>