[FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

[Kacper Michajlow]

On Fri, 22 Dec 2023 at 14:57, Anton Khirnov <anton at khirnov.net> wrote:
>
> Quoting Andreas Rheinhardt (2023-12-22 14:48:45)
> > Avoids relocations.
> >
> > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> > ---
>
> Maybe mention that it's not needed after
> acf63d5350adeae551d412db699f8ca03f7e76b9.

This is not the only user of this API, no?

I have a question for my own curiosity. This is ABI (and API) breaking
change, shouldn't there be a documentation change to indicate this
item_name function pointer can be null now? Or otherwise a way to
indicate that this should be updated in client applications?

It is easy fix, but it is kinda surprising to break over 14 year old
code like in mpv, see: https://github.com/mpv-player/mpv/pull/13154

- Kacper

> LGTM otherwise.
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".