[FFmpeg-devel] [PATCH] avfoundation: Fix version checks

[Zhao Zhili]

> On Dec 15, 2023, at 19:41, Thilo Borgmann via ffmpeg-devel <ffmpeg-devel at ffmpeg.org> wrote:
> 
> Am 15.12.23 um 12:32 schrieb Martin Storsjö via ffmpeg-devel:
>> On Fri, 15 Dec 2023, Zhao Zhili wrote:
>>> 
>>>> On Dec 15, 2023, at 18:11, Martin Storsjö <martin at martin.st> wrote:
>>>> 
>>>> <OS>_VERSION_MAX_ALLOWED indicates what version is available in
>>>> the SDK, while <OS>_VERSION_MIN_REQUIRED is the version we can
>>>> assume is available, i.e. similar to what is set with e.g.
>>>> -miphoneos-version-min on the command line.
>>>>                                     ^
>>> 
>>> I think we need some utils for version check on Apple’s multiple target OS. It’s hard
>>> to get it right and very lengthy to write. Ping Marvin since he is expert on this
>>> subject.
>>> 
>>> And can we setup a group of CI for these platforms?
>> That would be good.
>> We do have a mac mini running fate tests; it would probably be good to add test configurations that build for both macOS and iOS, for both whatever the latest version in the installed SDK is, and with an old deployment target (those builds often get broken).
>> (And then, someone would need to check the FATE status as well.)
> 
> That would be great!
> Fate on the M1 discovered the other bug about the availability macro in audiotoolbox only because it used the 11.3 SDK on a 12.0 OS.
> 
> Marvin knows this OS specific stuff way better than me, it would be great if he wanted to set it up more sophisticated :)


Two other similar bugs:

https://trac.ffmpeg.org/ticket/10690
https://trac.ffmpeg.org/ticket/10695

It’s easy to workaround by !TARGET_OS_IPHONE, but I want to enable it for as many platforms as possible.
I haven’t got the time to read Marvin’s article and figure out how to do it properly yet.

> 
> -Thilo
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".