[FFmpeg-devel] [PATCH] lavc/libopenh264: Drop openh264 runtime version checks

[Kalev Lember]

On Fri, Dec 8, 2023 at 1:00 PM Martin Storsjö <martin at martin.st> wrote:

> On Fri, 8 Dec 2023, Kalev Lember wrote:
>
> > As for dlopening, I think instead of version checks, it would make sense
> to
> > try to dlsym() all of the actual required symbols, and error out in init
> if
> > anything is missing. That should make it all super flexible and
> resilient to
> > e.g. struct size changes that would normally be an ABI change.
>
> How would that help, if e.g. the SEncParamExt struct in svc_encode_init
> would change layout/size - which part would notice that change?
>

Ah, hm, I didn't think this through apparently :) This would indeed still
be an issue.

I guess maybe dlopening the soname version that matches the headers (e.g.
libopenh264.so.7) would work then? With the expectation that upstream bumps
soname whenever the struct layout/size changes.

-- 
Kalev