[FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

[Anton Khirnov]

Quoting Nicolas George (2023-04-24 13:59:43)
> Anton Khirnov (12023-04-24):
> > We'll have to disagree about this then. I belive lack of proper
> > structure is currently the biggest problem in ffmpeg CLI.
> 
> I do not disagree on this. But this patch does not help, it just makes
> the code locally less readable. If it is to be useful at all, it is at
> least severely premature.

What exactly is less readable? One variable gets its scope reduced, that
is a win in my book. And obviously I'm not stopping there, other things
will be moved to this private struct in future patches, I just prefer to
avoid giant patchsets when possible.
Also note that exactly the same pattern is used in ffmpeg_demux,
ffmpeg_mux, and ffmpeg_enc (and soon in ffmpeg_dec).

-- 
Anton Khirnov