[FFmpeg-devel] [PATCH 1/6] avcodec/g723_1enc: Remove unnecessary av_clipl_int32()
Andreas Rheinhardt
andreas.rheinhardt at outlook.com
Wed Sep 28 21:56:58 EEST 2022
partial_corr is an int16_t and so the av_clipl_int32()
never clips and can be removed. This also avoids
undefined left-shifts of negative numbers.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
libavcodec/g723_1enc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavcodec/g723_1enc.c b/libavcodec/g723_1enc.c
index f3baf7b4ec..a22985ca44 100644
--- a/libavcodec/g723_1enc.c
+++ b/libavcodec/g723_1enc.c
@@ -200,8 +200,7 @@ static void levinson_durbin(int16_t *lpc, int16_t *autocorr, int16_t error)
partial_corr = temp / (error << 1);
- lpc[i] = av_clipl_int32((int64_t) (partial_corr << 14) +
- (1 << 15)) >> 16;
+ lpc[i] = (partial_corr + (1 << 1)) >> 2;
/* Update the prediction error */
temp = MULL2(temp, partial_corr);
--
2.34.1
More information about the ffmpeg-devel
mailing list