[FFmpeg-devel] [PATCH] lavu/riscv: fix off-by-one in bit-magnitude clip

remi at remlab.net remi at remlab.net
Thu Sep 15 21:26:48 EEST 2022


From: Rémi Denis-Courmont <remi at remlab.net>

---
 libavutil/riscv/intmath.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavutil/riscv/intmath.h b/libavutil/riscv/intmath.h
index 3263a79dc4..45bce9a0e7 100644
--- a/libavutil/riscv/intmath.h
+++ b/libavutil/riscv/intmath.h
@@ -61,8 +61,8 @@ static av_always_inline av_const int32_t av_clipl_int32_rvi(int64_t a)
 #define av_clip_intp2 av_clip_intp2_rvi
 static av_always_inline av_const int av_clip_intp2_rvi(int a, int p)
 {
-    const int shift = 32 - p;
-    int b = (a << shift) >> shift;
+    const int shift = 31 - p;
+    int b = ((int)(((unsigned)a) << shift)) >> shift;
 
     if (a != b)
         b = (a >> 31) ^ ((1 << p) - 1);
-- 
2.37.2



More information about the ffmpeg-devel mailing list