[FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

[Mohammad Izadi]

Thank you Derek for your comment ! It’s fixed.


On Wed, Sep 7, 2022 at 6:13 AM Derek Buitenhuis <derek.buitenhuis at gmail.com>
wrote:

> On 9/6/2022 10:47 PM, Mohammad Izadi wrote:
> > +    if (side_data && side_data_size > 0)
> > +
> ff_write_dynamic_hdr10_plus_to_full_itu_t_t35((AVDynamicHDRPlus*)side_data,
> &hdr10_plus_itu_t_t35, &hdr10_plus_itu_t_t35_size);
>
> You can't use ff_-prefixed functions across library boundaries.
>
> It nees to be either public (av*) or avpriv. I suspect people won't want
> it to
> be avpriv.
>
> Personally, I think having serialization as a public API is useful, but
> YMMV. Mostly
> because I was just writing my own serialization to make use of the
> exported side data :P.
>
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>