[FFmpeg-devel] [PATCH 3/3] avcodec/bink: disallow odd positioned scaled blocks

[Anton Khirnov]

Quoting Michael Niedermayer (2022-09-02 00:34:36)
> On Tue, Jul 12, 2022 at 08:20:18PM +0200, Michael Niedermayer wrote:
> > On Tue, Jun 14, 2022 at 12:09:59AM +0200, Michael Niedermayer wrote:
> > > On Tue, Jun 14, 2022 at 12:01:14AM +0200, Paul B Mahol wrote:
> > > > On Mon, Jun 13, 2022 at 11:55 PM Michael Niedermayer <michael at niedermayer.cc>
> > > > wrote:
> > > > 
> > > > > On Mon, Jun 13, 2022 at 10:02:24AM +0200, Paul B Mahol wrote:
> > > > > > Have you checked this with longer samples?
> > > > >
> > > > > ive tested it with the files in the bink directory on samples
> > > > > anything else i should test it with ?
> > > > >
> > > > 
> > > > Something longer, where is big gap between keyframes.
> > > 
> > > I would have thought that some of the 46 files in the samples archieve
> > > would have adequate gaps.
> > > Can you share some better test file ?
> > 
> > ping ?
> > anyone has more files i should test ?
> > if not, i suggest to apply this
> 
> google will publish this report in 5 days
> just a reminder this is a out of array write and it will be very easily
> searchable so anyone looking for unfixed bugs to exploit will try to
> exploit this

Then push the patch and see if anyone comes up with any samples.

-- 
Anton Khirnov