[FFmpeg-devel] [crop support for matroska demuxer 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters.

[Timo Rothenpieler]

On 01.10.2022 08:13, OvchinnikovDmitrii wrote:
> ---
>   libavcodec/avcodec.h   | 8 ++++++++
>   libavcodec/codec_par.h | 8 ++++++++
>   2 files changed, 16 insertions(+)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 7365eb5cc0..66df571afc 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -585,6 +585,14 @@ typedef struct AVCodecContext {
>        */
>       int coded_width, coded_height;
>   
> +    /**
> +     * The dimensions of the crop, usually from container.
> +     */
> +    int crop_top;
> +    int crop_left;
> +    int crop_bottom;
> +    int crop_right;
> +

Shouldn't these be added at the very end, to not break ABI?

I'm also not very convinced this kind of information really belongs into 
AVCodecContext and codecpar.
Can't it just be frame-sidedata?