[FFmpeg-devel] [PATCH 2/5] lavf/demux: treat EAGAIN as REDO unless AVFMT_FLAG_NONBLOCK is set

Michael Niedermayer michael at niedermayer.cc
Thu Nov 10 21:52:33 EET 2022


On Thu, Nov 10, 2022 at 01:31:44PM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2022-11-10 13:28:27)
> > On Tue, Nov 08, 2022 at 12:25:47PM +0100, Anton Khirnov wrote:
> > > Lavf only supports a very limited approximation of non-blocking
> > > behavior, so we should not return random EAGAINs to callers unless they
> > > specifically requested it.
> > > ---
> > >  libavformat/demux.c | 8 ++++++--
> > >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > this changes seeking behavior of for example:
> > libavformat/tests/seek fate-suite/dss/sp.dss
> > 
> > (this seemed to return EAGAIN before sometimes)
> 
> Are you saying that is wrong? I don't see why seeks should return EAGAIN
> either.

I do not know if its wrong or not. I remember some seeking used error
returns to switch to generic seeking and such stuff.
I just reporrted this as i saw a difference in the tests/seek output

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20221110/1afaae9c/attachment.sig>


More information about the ffmpeg-devel mailing list