[FFmpeg-devel] [PATCH 0/3] sw_scale: Provide neon implementation for hscale

Martin Storsjö martin at martin.st
Tue Nov 1 15:26:11 EET 2022


On Fri, 28 Oct 2022, Hubert Mazur wrote:

> This patchset contains arm64 neon implementation of hscale functions.
> Fixed minor style issues and declared C function wrappers as static.
> This patchset do not contain the patch for checkasm tool, as the
> previous one did. The reason behind it was failing tests on x86 arch
> but not on aarch64 or loongarch. Probably the hscale functions on x86
> have some bugs. Currently the checkasm tool does not check
> the validity of hscale functions on x86 at all. Implementation of hscale
> for x86 should be fixed anyway. As it comes to aarch64 the tests were
> passing. Attaching a link to fate result in patchwork. After fixing x86
> the patch for checkasm could be merged.

It's too bad that we don't have that test mergeable at this point, but I 
guess we can't hold back the new aarch64 assembly due to that...

The patches seem fine as noted before; I found some more cases of missing 
trailing newlines at the end of the file, and some other minor stray 
changes in the patches, which I fixed. I also amended the commit messages 
saying that some of the benchmarks are from the non-merged checkasm test.

With that, I pushed these patches.

// Martin



More information about the ffmpeg-devel mailing list