[FFmpeg-devel] [PATCH 1/2] avformat/movenc: enable compressorname for mp4 mode

Zhao Zhili quinkblack at foxmail.com
Mon May 30 10:49:22 EEST 2022


Signed-off-by: Zhao Zhili <quinkblack at foxmail.com>
---
 libavformat/movenc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index de971f94e8..c2dc354ed3 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -2121,7 +2121,9 @@ static void find_compressor(char * compressor_name, int len, MOVTrack *track)
                   || (track->par->width == 1440 && track->par->height == 1080)
                   || (track->par->width == 1920 && track->par->height == 1080);
 
-    if ((track->mode == MODE_AVIF || track->mode == MODE_MOV) &&
+    if ((track->mode == MODE_AVIF ||
+         track->mode == MODE_MOV ||
+         track->mode == MODE_MP4) &&
         (encoder = av_dict_get(track->st->metadata, "encoder", NULL, 0))) {
         av_strlcpy(compressor_name, encoder->value, 32);
     } else if (track->par->codec_id == AV_CODEC_ID_MPEG2VIDEO && xdcam_res) {
@@ -2210,7 +2212,6 @@ static int mov_write_video_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex
     avio_wb32(pb, 0); /* Data size (= 0) */
     avio_wb16(pb, 1); /* Frame count (= 1) */
 
-    /* FIXME not sure, ISO 14496-1 draft where it shall be set to 0 */
     find_compressor(compressor_name, 32, track);
     avio_w8(pb, strlen(compressor_name));
     avio_write(pb, compressor_name, 31);
-- 
2.35.3



More information about the ffmpeg-devel mailing list