[FFmpeg-devel] [PATCH v6] avcodec/mfenc: Dynamically load MFPlat.DLL
Trystan Mata
trystan.mata at tytanium.xyz
Thu May 26 09:34:05 EEST 2022
> In testing of it, I noted that you still need to link against -lmfuuid
> when building with MSVC (but in mingw, those UUIDs are defined inline in
> headers I think).
Ah, I just used used mingw for my testing, sorry.
> Additionally, I realized I do prefer to keep using plain LoadLibraryA
> and FreeLibrary instead of using the wrapper, as this file is all quite
> Windows specific code; using the direct Windows APIs makes it clearer
> what's going on.
I'm not used at all to the Windows APIs,
> Finally, I removed the extra "" in the GetProcAddress call - I don't
> remember if you ever responded to why that was there.
I didn't see the "Why the extra "" here?", it was the first time that I
did a macro with conversion to text. I just thought that at least a ""
was required to text convert with #.
> As the patch seemed fine otherwise, I went ahead and pushed it. Thanks!
Thank for your reviews !
// Trystan
More information about the ffmpeg-devel
mailing list