[FFmpeg-devel] [PATCH 1/3] fftools: Stop using av_fopen_utf8

[Martin Storsjö]

On Mon, 23 May 2022, Soft Works wrote:

> Great. I rebased and resubmitted both patchsets. The primary long-path
> patchset didn't need any change.
>
> Considerations for the latter were:
>
> - Should the file wchar_filename.h be renamed as it is now containing
>  the path prefixing code?

I guess we could do that later at some point, but I don't see it as 
urgent.

> - I have kept the path functions in the same way like .NET does it,
>  just for easy reference and following. Compilers will inline
>  them anyway (my pov). Maybe others don't like that. I can change
>  if it's got to be.

Having the individual functions inline compared to merging it all in one 
big function doesn't matter to me. But the amount of code in this inline 
header is growing a bit big, to the point that I think it is measurable 
when multiple files within the same library use these functions. Longer 
term, it would probably make sense to make them more shared in some way.

If C would have the C++ style deduplication feature for non-static inline 
functions, this wouldn't be an issue. One could consider making them ff_ 
functions and carry a copy in each library too, maybe. (But that also 
makes it trickier to use in fftools.) Not entirely urgent yet anyway.

// Martin