[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

"zhilizhao(赵志立)" quinkblack at foxmail.com
Wed May 4 20:10:04 EEST 2022



> On May 5, 2022, at 12:45 AM, Vignesh Venkatasubramanian <vigneshv-at-google.com at ffmpeg.org> wrote:
> 
>>> 
>>> -    mov_write_track_udta_tag(pb, mov, st);
>>> +    if (track->mode != MODE_AVIF)
>>> +        mov_write_track_udta_tag(pb, mov, st);
>> 
>> Please check if the check can be removed. mov_write_track_udta_tag() does nothing
>> for mode other than MOV/MP4.
>> 
> 
> mov_write_track_udta_tag() writes itunes meta and loci tags when mode
> is not MOV/MP4. So this check is necessary.
> 

I think you are referring to ‘mov_write_udta_tag', not
‘mov_write_track_udta_tag', no?


More information about the ffmpeg-devel mailing list