[FFmpeg-devel] Need help submitting a patch

[Traian Coza]

Thanks. I'll use the ffstaging/FFmpeg repo. I didn't know about that, it
seems much simpler. I've tried using -n (n= number of commits), but it only
generates n emails, I only want 1.

I have another concern before I create a pull request. I ran 'make fate'
like it says on the website for regression testing, and I got the following
error:

TEST    source
--- ./tests/ref/fate/source 2022-05-02 12:57:02.707487436 -0400
+++ tests/data/fate/source 2022-05-03 09:22:31.302681114 -0400
@@ -5,6 +5,8 @@
 libavcodec/interplayacm.c
 libavcodec/log2_tab.c
 libavcodec/reverse.c
+libavcodec/text_to_bitmap.c
+libavcodec/text_to_bitmap.h
 libavdevice/file_open.c
 libavdevice/reverse.c
 libavfilter/af_arnndn.c
@@ -20,6 +22,7 @@
 compat/djgpp/math.h
 compat/float/float.h
 compat/float/limits.h
+libavcodec/text_to_bitmap.h
 tools/decode_simple.h
 Use of av_clip() where av_clip_uintp2() could be used:
 Use of av_clip() where av_clip_intp2() could be used:
Test source failed. Look at tests/data/fate/source.err for details.

The source.err file seems to be empty, however. Should I be concerned about
this? It seems to do with the fact that I've added some files.

On Tue, May 3, 2022 at 3:54 AM Nicolas George <george at nsup.org> wrote:

> Traian Coza (12022-05-03):
> > Hi! I am new to contributing to FFmpeg, and I have a technical question.
> >
> > I'm trying to submit a patch, but it's a fairly large patch, which I've
> > made in multiple commits. I don't know how to generate the email for this
> > patch. The example command given on the website (with format-patch) only
> > generates the email for a single commit. I've searched the web and I
> don't
> > really see an easy way to do it. Can someone help me out with this?
>
> First, make sure your multiple commits are really there: check they are
> all visible in `git log`.
>
> Then, what is your git format-patch exact command? If it ends in "-1",
> then the result you are seeing is normal: the -1 is telling it to take
> the last patch.
>
> You need to tell git format-patch the last commit before yours. You can
> get it from `git log`. It would be even simpler if you thought of making
> a branch: then you just need to specify the name of the branch from
> which you branched.
>
> Regards,
>
> --
>   Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>