[FFmpeg-devel] [PATCH] MAINTAINERS: add Niklas Haas for vf_libplacebo.c

[Lynne]

28 Mar 2022, 23:13 by ffmpeg at haasn.xyz:

> On Mon, 28 Mar 2022 22:31:36 +0200 Lynne <dev at lynne.ee> wrote:
>
>> I'm not okay with this. I don't mind anyone pushing approved patches,
>> but I still want to review and have final say on all Vulkan code. Could you
>> change that?
>>
>
> The contents of vf_libplacebo is not "Vulkan code". The only thing
> Vulkan about it is the minimal plumbing between AVFrame and libplacebo,
> most of which is actually already happening inside libplacebo's codebase
> (<utils/libav.h`) where I already have complete control over it.
>

Device creation's still done from the lavu-side of things.


> If anything, I still want to move this filter away from being
> Vulkan-exclusive in the future, which would make it even more decoupled
> from your concern.
>

I explicitly told you that's okay when the filter first got merged,
but you didn't change it back then, and I've been waiting for you
to enable it.