[FFmpeg-devel] [PATCH] avformat/mov: Initialize padding of buffer

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Wed Mar 23 13:25:16 EET 2022


Fixes ticket #9695.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
No value read from the padding is actually used at all;
Valgrind is smart enough to detect this and not warn about this.
MemorySanitizer is unfortunately not. Do we treat such issues
as real or just close them as false positives?

 libavformat/mov.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 6c847de164..ff2824abad 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -2923,6 +2923,7 @@ static int mov_read_stsz(MOVContext *c, AVIOContext *pb, MOVAtom atom)
         av_log(c->fc, AV_LOG_WARNING, "STSZ atom truncated\n");
         return 0;
     }
+    memset(buf + num_bytes, 0, AV_INPUT_BUFFER_PADDING_SIZE);
 
     init_get_bits(&gb, buf, 8*num_bytes);
 
-- 
2.32.0



More information about the ffmpeg-devel mailing list