[FFmpeg-devel] [PATCH] movenc: Use LIBAVFORMAT_IDENT instead of LIBAVCODEC_IDENT

Martin Storsjö martin at martin.st
Sun Mar 13 00:28:54 EET 2022


On Sat, 12 Mar 2022, James Almer wrote:

>
>
> On 3/11/2022 11:23 AM, Martin Storsjö wrote:
>> The muxer seems to have had one seemingly accidental use of
>> LIBAVCODEC_IDENT, while LIBAVFORMAT_IDENT probably is the
>> relevant one (which is used multiple times in the same file).
>> 
>> Signed-off-by: Martin Storsjö <martin at martin.st>
>> ---
>>   libavformat/movenc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>> index 4c868919ae..a2c2145354 100644
>> --- a/libavformat/movenc.c
>> +++ b/libavformat/movenc.c
>> @@ -4108,7 +4108,7 @@ static int mov_write_uuidusmt_tag(AVIOContext *pb, 
> AVFormatContext *s)
>>           avio_wb16(pb, 0x021C);               /* data */
>>
>>           if (!(s->flags & AVFMT_FLAG_BITEXACT))
>> -            mov_write_psp_udta_tag(pb, LIBAVCODEC_IDENT,      "eng", 
> 0x04);
>> +            mov_write_psp_udta_tag(pb, LIBAVFORMAT_IDENT,      "eng", 
> 0x04);
>>           mov_write_psp_udta_tag(pb, title->value,          "eng", 0x01);
>>           mov_write_psp_udta_tag(pb, "2006/04/01 11:11:11", "und", 0x03);
>> 
>
> LGTM

Thanks, pushed.

// Martin


More information about the ffmpeg-devel mailing list