[FFmpeg-devel] [PATCH] avfilter/framepool: remove superfluous pallete buffer allocation

James Almer jamrial at gmail.com
Thu Mar 3 19:05:48 EET 2022


av_image_fill_plane_sizes() already sets sizes[1] to AVPALETTE_SIZE.
Should fix memory leaks.

Signed-off-by: James Almer <jamrial at gmail.com>
---
Sorry for not noticing this before.

 libavfilter/framepool.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c
index 96bfe46319..1990902666 100644
--- a/libavfilter/framepool.c
+++ b/libavfilter/framepool.c
@@ -56,13 +56,9 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* (*alloc)(size_t size),
 {
     int i, ret;
     FFFramePool *pool;
-    const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(format);
     ptrdiff_t linesizes[4];
     size_t sizes[4];
 
-    if (!desc)
-        return NULL;
-
     pool = av_mallocz(sizeof(FFFramePool));
     if (!pool)
         return NULL;
@@ -108,12 +104,6 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* (*alloc)(size_t size),
             goto fail;
     }
 
-    if (desc->flags & AV_PIX_FMT_FLAG_PAL) {
-        pool->pools[1] = av_buffer_pool_init(AVPALETTE_SIZE, alloc);
-        if (!pool->pools[1])
-            goto fail;
-    }
-
     return pool;
 
 fail:
-- 
2.35.1



More information about the ffmpeg-devel mailing list