[FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: remove direct=1 support

Paul B Mahol onemda at gmail.com
Wed Mar 2 21:11:18 EET 2022


On 3/2/22, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Wed, Mar 02, 2022 at 12:38:05PM +0100, Paul B Mahol wrote:
>> It seems it does not work properly.
>>
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  libavcodec/mpegvideo_enc.c | 23 +++--------------------
>>  1 file changed, 3 insertions(+), 20 deletions(-)
>
> if iam not mistaken, that requires the whole image to  be copied
> one extra time
> i think before doing that it should be understood
> where the problem is
> and why that is the better solution to fixing it and not doing
> that extra copy
>
> of course i may be missing something
>

Yea, If you manage to trigger that path, I'm all ears.

> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Opposition brings concord. Out of discord comes the fairest harmony.
> -- Heraclitus
>


More information about the ffmpeg-devel mailing list