[FFmpeg-devel] [PATCH v2 1/2] tools: add general_assembly.pl

[J. Dekker]

On 24 Feb 2022, at 14:46, Nicolas George wrote:

> Thilo Borgman (12022-02-24):
>> Both LGTM.
>
> Does it?

An earlier reply would have been helpful here, i.e. before an ACK rather than after.

> The way I remember it, this condition was for the initial assembly, as a
> temporary measure. I might have missed some steps, but I do not remember
> we adopted this as a constant rule.
>
> I see several flaws with it:
>
> - Documentation patches were not counted, now they are.
>
> - Cosmetic patches are counted.
>
> - It does not take the size of the changes.
>
> Using an imperfect solution for bootstrap is one thing, using it
> permanently is another.
>

It is only supposed to match the documentation. Of course, nothing says it can't be changed later when the 'bootstrap' process is completed (and let's consider that the last time this was actually discussed was in Tokyo, not sure what good delaying it further helps).

You are welcome to send a patch to our documentation to clarify the rules if you think they are not correct. However, I personally think that any contribution to the project is useful and documentation & cosmetic improvements should not be penalized needlessly.

-- 
J. Dekker