[FFmpeg-devel] [PATCH v1 2/4] lavc/hevcdec: do not let missing ref frames invovled in dpb process

[Wang, Fei W]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Michael Niedermayer
> Sent: Thursday, June 9, 2022 10:05 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v1 2/4] lavc/hevcdec: do not let missing ref
> frames invovled in dpb process
> 
> On Thu, Jun 09, 2022 at 05:34:47AM +0000, Wang, Fei W wrote:
> > > -----Original Message-----
> > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > > Michael Niedermayer
> > > Sent: Tuesday, June 7, 2022 8:07 PM
> > > To: FFmpeg development discussions and patches
> > > <ffmpeg-devel at ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] [PATCH v1 2/4] lavc/hevcdec: do not let
> > > missing ref frames invovled in dpb process
> > >
> > > On Tue, Jun 07, 2022 at 03:08:28PM +0800, Fei Wang wrote:
> > > > From: Xu Guangxin <guangxin.xu at intel.com>
> > > >
> > > > We will generate a new frame for a missed reference. The frame can
> > > > only be used for reference. We assign an invalid decode sequence
> > > > to it, so it will not be involved in any dpb process.
> > > >
> > > > Tested-by: Fei Wang <fei.w.wang at intel.com>
> > > > Signed-off-by: Xu Guangxin <guangxin.xu at intel.com>
> > > > ---
> > > >  libavcodec/hevc_refs.c | 13 ++++++++++++-
> > > >  libavcodec/hevcdec.c   |  4 ++--
> > > >  libavcodec/hevcdec.h   |  3 +++
> > > >  3 files changed, 17 insertions(+), 3 deletions(-)
> > >
> > > This causes segfaults
> >
> > Thanks Michael, could you share your clip to me? I can't reproduce this with all
> my clips.
> 
> file sent by private mail

Fixed in V2.

Thanks
Fei

> 
> thx
> 
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> The smallest minority on earth is the individual. Those who deny individual rights
> cannot claim to be defenders of minorities. - Ayn Rand