[FFmpeg-devel] [PATCH v12 1/4] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Soft Works
> Sent: Thursday, June 9, 2022 6:47 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v12 1/4] libavutil/wchar_filename.h: Add
> whcartoutf8, wchartoansi and utf8toansi
> 
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Martin
> > Storsjö
> > Sent: Thursday, June 9, 2022 12:10 PM
> > To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH v12 1/4] libavutil/wchar_filename.h: Add
> > whcartoutf8, wchartoansi and utf8toansi
> >
> > On Sun, 5 Jun 2022, Nil Admirari wrote:
> >
> > > These functions are going to be used in libavformat/avisynth.c
> > > and fftools/cmdutils.c to remove MAX_PATH limit.
> > > ---
> > > libavutil/wchar_filename.h | 51 ++++++++++++++++++++++++++++++++++++++
> > > 1 file changed, 51 insertions(+)
> >
> > This patchset looks good to me too, thanks! If there's no more comments on
> > it, I'll push it later.
> 
> I missed to take another look at it.
> 
> I'm wondering why it converts wchar back to ansi instead of utf8 in 4/4 and
> whether it won't fail then, when a path contains non-ANSI chars.

@Nil - would you mind rebasing your patchset, it doesn't apply anymore.

Thanks,
sw