[FFmpeg-devel] [PATCH 2/2] tests/ref/fate/filter-metadata-cropdetect[12]: Fix ref file

James Almer jamrial at gmail.com
Sun Jul 31 00:00:10 EEST 2022


On 7/30/2022 5:25 PM, Andreas Rheinhardt wrote:
> Necessitated by 6ca43a9675d651d7ea47c7ba2fafb1bf831c4d0b
> and 425b309fa43236f4b7c098c7829b70a421fc1dd7.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
> Did someone ever look why 6ca43a9675d651d7ea47c7ba2fafb1bf831c4d0b
> made these changes?

My guess (because i only gave the code a cursory look) is that, since 
we're now passing the frame as generated by lavfi through untouched, 
what might have been empty frame metadata tags that 
av_packet_pack_dictionary() was skipping when copying them to the packet 
are now reflected (Or maybe av_packet_unpack_dictionary() is what was 
skipping them from the raw data buffer when decoding the packet).


More information about the ffmpeg-devel mailing list