[FFmpeg-devel] [PATCH 37/39] avcodec/mpegvideo_motion: Constify ff_mpv_motion

Michael Niedermayer michael at niedermayer.cc
Fri Jul 29 01:03:55 EEST 2022


On Wed, Jul 27, 2022 at 12:08:12AM +0200, Andreas Rheinhardt wrote:
> Also constify the corresponding code in mpegvideo.c that handles
> lowres.
> (Unfortunately, not everything that is const could be constified:
> ref_picture could be made const uint8_t* const* if C allowed the
> safe automatic conversion from uint8_t**; and pix_op, qpix_op
> could be made to point to const function pointers, but C's handling
> of const in pointers to arrays is broken.)
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  libavcodec/mpegvideo.c        | 24 ++++++++++----------
>  libavcodec/mpegvideo.h        |  2 +-
>  libavcodec/mpegvideo_motion.c | 41 ++++++++++++++++++-----------------
>  libavcodec/wmv2.c             |  4 ++--
>  libavcodec/wmv2.h             |  2 +-
>  5 files changed, 37 insertions(+), 36 deletions(-)

LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220729/a7903e9b/attachment.sig>


More information about the ffmpeg-devel mailing list