[FFmpeg-devel] [PATCH 22/35] fftools: add an object pool

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Fri Jul 22 20:58:04 EEST 2022


Anton Khirnov:
> Hi,
> Quoting Andreas Rheinhardt (2022-06-16 23:41:36)
>> AVFifos are often used with non-POD elements that need custom init,
>> reset (unref) and free callbacks (in addition to the move callbacks
>> already supported). So why not add it to AVFifo? The only drawback to
>> this that I see is that the pool could not be shared among multiple
>> AVFifos, but apart from that it should support the usecases that you
>> propose and do so in a way that avoids having to drain the fifos
>> manually when freeing it.
> 
> Since neither of us seems to have much time to deal with this right now
> --- would you object to me pushing this set as is (Michael confirmed on
> IRC he is done testing it) and leaving the objpool question for later?
> Objpool is fully private, so it can always be changed or removed at
> will.
> 

I don't object to this approach. Sorry for not having time to do any
testing/reviewing.

- Andreas


More information about the ffmpeg-devel mailing list