[FFmpeg-devel] [PATCH] Make implicit void pointer cast explicit

Amir Mazzarella amirmazz at google.com
Wed Jul 20 01:12:26 EEST 2022


On Tue, Jul 19, 2022 at 2:24 PM Nicolas George <george at nsup.org> wrote:
> Thanks for clarifying. I confess I had more or less guessed. FFmpeg is
> C, and its headers, public or not, as a rule do not contain
> accommodations to be included as is in other languages.

I understand that FFmpeg does not contain accommodations, but in my
opinion it is less of an accommodation and more for readability, avoiding
an implicit cast. An explicit void pointer cast, like the one presented in
my patch, is done elsewhere in FFmpeg code as well.
See https://github.com/FFmpeg/FFmpeg/blob/master/libavutil/hwcontext_qsv.c#L316
What's the harm in including this one too?


More information about the ffmpeg-devel mailing list