[FFmpeg-devel] [PATCH 1/3] hwcontext_vaapi: do not link against libva-x11.so

[Michael Niedermayer]

On Tue, Jul 19, 2022 at 05:56:54PM +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> There is an internal ABI between libva.so the libva-XXX.so libraries.
> 
> With a recent change, the internal va_fool API was removed breaking the
> ABI. So if libva.so and libva-x11.so are from different version, the
> whole stack will crash.
> 
> Instead we can dlopen() the libva-x11 library and gracefully error out.
> 
> Cc: Mark Thompson <sw at jkqxz.net>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Greetings team, please consider backporting this for the stable
> releases.
> 
> I've noticed that we've got plenty of pre-existing memory and state
> leaks in vaapi_device_create(). Would it make sense to fix those up? If
> so I can follow-up with a patch.
> ---
>  configure                   |  2 +-
>  libavutil/hwcontext_vaapi.c | 34 +++++++++++++++++++++++++++++++++-
>  2 files changed, 34 insertions(+), 2 deletions(-)

../configure --enable-gpl --cc='ccache gcc'  --enable-version3    --enable-vdpau
make -j32
...
LD	ffmpeg_g
/usr/bin/ld: libavutil/libavutil.a(hwcontext_vaapi.o): undefined reference to symbol 'dlclose@@GLIBC_2.2.5'
//lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
/home/michael/ffmpeg-git/ffmpeg/Makefile:131: recipe for target 'ffmpeg_g' failed
make: *** [ffmpeg_g] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220720/24e7fa93/attachment.sig>