[FFmpeg-devel] [PATCH v2 6/6] avcodec/encode:: generate ICC profiles

[Niklas Haas]

On Wed, 06 Jul 2022 15:35:41 +0200 Anton Khirnov <anton at khirnov.net> wrote:
> Quoting Niklas Haas (2022-06-29 12:12:51)
> > From: Niklas Haas <git at haasn.dev>
> > 
> > Only if requested, and only if the codec signals support for ICC
> > profiles. Implementation roughly matches the functionality of the
> > existing vf_iccgen filter, albeit with some reduced flexibility and no
> > caching.
> > 
> > Ideally, we'd also only do this on the first frame (e.g. mjpeg, apng),
> > but there's no meaningful way for us to distinguish between this case
> > and e.g. somebody using the image2 muxer, in which case we'd want to
> > attach ICC profiles to every frame in the stream.
> 
> AV_CODEC_FLAG_GLOBAL_HEADER?

This seems marginally unrelated - apng etc. don't have extradata, and
none of the relevant codecs set this flag either. At best we could
introduce a new flag, but to be honest I don't think it's a huge issue
because apng and mjpeg with ICC profiles are exceptionally rare, and the
worst case is merely wasting some file space.

> 
> -- 
> Anton Khirnov