[FFmpeg-devel] [PATCH 2/5] checkasm: motion: Make the benchmarks more stable

Swinney, Jonathan jswinney at amazon.com
Fri Jul 15 22:35:47 EEST 2022


LGTM.

-- 

Jonathan Swinney

On 7/13/22, 3:49 PM, "Martin Storsjö" <martin at martin.st> wrote:

    CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



    Don't use the last random offset, but a static one.
    ---
     tests/checkasm/motion.c | 3 ++-
     1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tests/checkasm/motion.c b/tests/checkasm/motion.c
    index 79e4358941..87b20d1c10 100644
    --- a/tests/checkasm/motion.c
    +++ b/tests/checkasm/motion.c
    @@ -81,7 +81,8 @@ static void test_motion(const char *name, me_cmp_func test_func)
                     break;
                 }
             }
    -        // benchmark with the final value of ptr
    +        // Test with a fixed offset, for benchmark stability
    +        ptr = img2 + 3 * WIDTH + 3;
             bench_new(NULL, img1, ptr, WIDTH, 8);
         }
     }
    --
    2.25.1




More information about the ffmpeg-devel mailing list