[FFmpeg-devel] [PATCH 1/6] avcodec/wnv1: Check for width =1

[Michael Niedermayer]

On Sun, Jul 03, 2022 at 08:38:15AM +0200, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > The decoder only outputs pixels for width >1 images, fail early
> > 
> > Fixes: Timeout
> > Fixes: 48298/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WNV1_fuzzer-6198626319204352
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/wnv1.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/libavcodec/wnv1.c b/libavcodec/wnv1.c
> > index 0cf2181a48..f1223493fe 100644
> > --- a/libavcodec/wnv1.c
> > +++ b/libavcodec/wnv1.c
> > @@ -129,6 +129,9 @@ static av_cold int decode_init(AVCodecContext *avctx)
> >  
> >      ff_thread_once(&init_static_once, wnv1_init_static);
> >  
> > +    if (avctx->width <= 1)
> > +        return AVERROR_INVALIDDATA;
> > +
> >      return 0;
> >  }
> >  
> 
> If you want to fail early, then why don't you do so before initializing
> the static data?

"early" in the sense of costly operations causing timeouts but 
will apply with it moved up

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220704/3e0fcca3/attachment.sig>